Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a rule with
hour_of_day
validations, and asking for occurrences on the day that DST skips forward, valid occurrences would be missed.Adding the hour of day here was simply adding the hour to the start time, causing the result to pass an occurrence.
Using the spec example where the validation is set to the 19th hour of each day:
For this situation, changing the
TimeWrapper
to usedst_adjust: true
seems to be a clear choice. The specs did not contain any examples that were adversely affected by this change, but please let me know if anything comes to mind.