Fixing biweekly realign when used with spans option. #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The realign method should be working from the pure opening time without the duration shift used for the spans option.
|
Thanks @jopotts and thank you for the note :) |
jopotts
added a commit
to bookwhen/ice_cube
that referenced
this pull request
May 5, 2017
avit
pushed a commit
to avit/ice_cube
that referenced
this pull request
Jun 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an edge case bug for the use of the spans option when the biweekly realign method comes into effect. The realign method was being called with the opening time with the duration shift, whereas it should always be using the pure opening time.
Thanks for all the work you've been doing on the gem recently! It's not gone unnoticed.