Add deprecations and settings for compatibility #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing :start_date to :start_time everywhere will take a while for some users due to serialized schedules that still have this key. For now we'll export both start_time and start_date in serialized output but this duplication should be removed in the next version. We will continue to read both :start_date and :start_time, with a preference for the new :start_time.
avit
added a commit
that referenced
this pull request
Mar 23, 2014
Add deprecations and settings for compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing :start_date to :start_time everywhere will take a while for some users due to serialized schedules that still have this key.
For now we'll export both start_time and start_date in serialized output but this duplication should be removed in the next version.
We will continue to read both :start_date and :start_time, with a preference for the new :start_time.