From ef1a35faf9f24e25ff6ccb977083ad56456cbc01 Mon Sep 17 00:00:00 2001 From: Oleksandr Redko Date: Mon, 16 Dec 2024 11:40:43 +0200 Subject: [PATCH] Simplify tests by using GinkgoT().TempDir() (#1265) --- analyzer_test.go | 7 ++----- helpers_test.go | 10 ++-------- 2 files changed, 4 insertions(+), 13 deletions(-) diff --git a/analyzer_test.go b/analyzer_test.go index f70b5fc475..153bc27525 100644 --- a/analyzer_test.go +++ b/analyzer_test.go @@ -17,7 +17,6 @@ package gosec_test import ( "errors" "log" - "os" "regexp" "strings" @@ -45,10 +44,8 @@ var _ = Describe("Analyzer", func() { Context("when processing a package", func() { It("should not report an error if the package contains no Go files", func() { analyzer.LoadRules(rules.Generate(false).RulesInfo()) - dir, err := os.MkdirTemp("", "empty") - defer os.RemoveAll(dir) - Expect(err).ShouldNot(HaveOccurred()) - err = analyzer.Process(buildTags, dir) + dir := GinkgoT().TempDir() + err := analyzer.Process(buildTags, dir) Expect(err).ShouldNot(HaveOccurred()) _, _, errors := analyzer.Report() Expect(errors).To(BeEmpty()) diff --git a/helpers_test.go b/helpers_test.go index 776397acf5..3349057574 100644 --- a/helpers_test.go +++ b/helpers_test.go @@ -17,14 +17,8 @@ var _ = Describe("Helpers", func() { Context("when listing package paths", func() { var dir string JustBeforeEach(func() { - var err error - dir, err = os.MkdirTemp("", "gosec") - Expect(err).ShouldNot(HaveOccurred()) - _, err = os.MkdirTemp(dir, "test*.go") - Expect(err).ShouldNot(HaveOccurred()) - }) - AfterEach(func() { - err := os.RemoveAll(dir) + dir = GinkgoT().TempDir() + _, err := os.MkdirTemp(dir, "test*.go") Expect(err).ShouldNot(HaveOccurred()) }) It("should return the root directory as package path", func() {