Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS handler issues #71

Open
r-work opened this issue Aug 26, 2024 · 3 comments
Open

iOS handler issues #71

r-work opened this issue Aug 26, 2024 · 3 comments
Labels
bug Bug or crash report triage approved The issue has been reviewed and approved for development

Comments

@r-work
Copy link

r-work commented Aug 26, 2024

Description

Secondary toolbar item dissapears when navigating away from page.

To Reproduce

  1. Create a detail page with secondary toolbar item.
  2. Create another page (lets call it page 2) with two secondary toolbar items.
  3. Run app.
  4. Detail page toolbar item appears correctly.
  5. Navigate to page 2, toolbar items appear as text.
  6. Close page 2, (should go back to detail page) now toolbar item dissapears on detail page.

Evidence

No response

App Version

1.0

OS Version

17.6.1

Diagnostic information

No response

@r-work r-work added the bug Bug or crash report label Aug 26, 2024
@github-actions github-actions bot added the triage pending Indicates that the issue is awaiting approval label Aug 26, 2024
@d2dyno1
Copy link
Member

d2dyno1 commented Aug 28, 2024

Will look into it soon 👀

@d2dyno1 d2dyno1 added triage approved The issue has been reviewed and approved for development and removed triage pending Indicates that the issue is awaiting approval labels Aug 28, 2024
@d2dyno1
Copy link
Member

d2dyno1 commented Aug 28, 2024

After some research, I came to a conclusion that rolling out a custom ToolbarItems property on the inherited ContentPage would be better.

  1. More options when setting item icon beyond just ImageSource (a good point to be made can be MauiIcons that pull icons from the font file)
  2. Item states (like checked/unchecked, disabled, etc)
  3. Nesting of menu items, section splitters, section titles:
iOS UIMenu Screenshot

IMG_0108

A good inspiration for the nesting of items would be to take from WinUI's MenuFlyoutItem* API. In terms of Android, a fallback could be used to the builtin ContentPage.ToolbarItems using OnPlatform (unless there's a specific need for more options. I currently haven't worked on porting it to Android)

Let me know what you think @r-work

@r-work
Copy link
Author

r-work commented Aug 28, 2024

Sounds good if it's not a massive amount of work.
Still hoping that MAUI team will be resolving the issue, though that might be a while.
Thanks for all your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug or crash report triage approved The issue has been reviewed and approved for development
Projects
None yet
Development

No branches or pull requests

3 participants
@d2dyno1 @r-work and others