Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In tests: We can reconsider the encryption of private keys #477

Closed
NabeelShahid7 opened this issue Dec 7, 2022 · 1 comment
Closed

In tests: We can reconsider the encryption of private keys #477

NabeelShahid7 opened this issue Dec 7, 2022 · 1 comment
Labels
legacy Issues related to legacy interfaces (obsolete with #731)

Comments

@NabeelShahid7
Copy link

Quite some time seems to be spent on decrypting private keys which can be reduced. Hence, the encryption of keys should only be done for cases that are actually testing key encryption/decryption and not for every other case.

The current runtime is around 42 seconds.

I will try to work on this.

@NabeelShahid7 NabeelShahid7 changed the title In tests: We can reconsider the encryption of private keys #115 In tests: We can reconsider the encryption of private keys Dec 7, 2022
@jku
Copy link
Collaborator

jku commented Dec 8, 2022

I think this is reasonable: there is API for encrypting, that should obviously be tested, but other key usage does not need encrypting. The other improvement area is not creating slow-to-generate keys (like rsa) if it's not needed by the test.

encryption/decryption and key generation are good guesses of time sinks but if you want to know for sure: I've used cProfile and snakeviz to try to understand where time is actually spent: http://jiffyclub.github.io/snakeviz/

@lukpueh lukpueh added the legacy Issues related to legacy interfaces (obsolete with #731) label Mar 14, 2024
@jku jku closed this as completed Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legacy Issues related to legacy interfaces (obsolete with #731)
Projects
None yet
Development

No branches or pull requests

3 participants