Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-platform verification of RSA PSS signatures #421

Closed
trishankatdatadog opened this issue Aug 4, 2022 · 1 comment · Fixed by #422
Closed

Cross-platform verification of RSA PSS signatures #421

trishankatdatadog opened this issue Aug 4, 2022 · 1 comment · Fixed by #422

Comments

@trishankatdatadog
Copy link
Contributor

trishankatdatadog commented Aug 4, 2022

Description of issue or feature request:

There are two related issues:

  1. The salt length used when creating RSA PSS signatures.
  2. And the salt length used when verifying these signatures.

Current behavior:

  1. We use a salt length equal to DIGEST_LENGTH when creating these signatures.
  2. Same for verifying them. This is a problem when verifying cross-platform signatures (e.g., from the Golang crypto/rsa packages, which uses a different salt length by default as described below; see Allow configuring the possible salt lengths for RSA PSS signatures hashicorp/vault#16549).

Expected behavior:

  1. Although optional, and not necessary for the cross-platform verification of signatures, we should use a salt length equal to MAX_LENGTH for the maximum provable security when creating these signatures.
  2. We should use a salt length equal to AUTO so that we can automatically verify these signatures regardless of the input salt length.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant