Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions in environment.yml #226

Closed
rffontenelle opened this issue Apr 28, 2024 · 1 comment · Fixed by #227
Closed

Update versions in environment.yml #226

rffontenelle opened this issue Apr 28, 2024 · 1 comment · Fixed by #227

Comments

@rffontenelle
Copy link
Contributor

rffontenelle commented Apr 28, 2024

Considering the versions update in requitements.txt and in Dockerfile, I assume we need to have environments.yml updated as well to keep rtd up with some versions. (I'd do myself but I'm not familiar with the version constraints in there)

P.s. consider enabling RTD preview for pull requests, see https://docs.readthedocs.io/en/stable/pull-requests.html

@sebp
Copy link
Owner

sebp commented Apr 28, 2024

Good catch, thanks for letting me know!

@sebp sebp closed this as completed in #227 Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants