From 023a49b2d9acf7968b72f3891ae608359d760c15 Mon Sep 17 00:00:00 2001 From: Gustavo Mauricio de Barros Date: Sat, 1 Feb 2025 13:24:55 -0300 Subject: [PATCH] Fix `StringValue.Create` encode overload. (#750) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Sébastien Ros --- Fluid.Tests/StringValueTests.cs | 12 ++++++++++++ Fluid/Values/StringValue.cs | 4 ++-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/Fluid.Tests/StringValueTests.cs b/Fluid.Tests/StringValueTests.cs index 76b89d85..88d15202 100644 --- a/Fluid.Tests/StringValueTests.cs +++ b/Fluid.Tests/StringValueTests.cs @@ -27,5 +27,17 @@ public void StringValueCreateNullShouldReturnEmpty() // Assert Assert.Equal(StringValue.Empty, stringValue); } + + [Theory] + [InlineData(true)] + [InlineData(false)] + public void StringValue_Create_InitializesProperties(bool encode) + { + var stringValue = StringValue.Create("a", encode); + + // Assert + Assert.Equal("a", stringValue.ToStringValue()); + Assert.Equal(encode, stringValue.Encode); + } } } diff --git a/Fluid/Values/StringValue.cs b/Fluid/Values/StringValue.cs index 1fc79879..172daeac 100644 --- a/Fluid/Values/StringValue.cs +++ b/Fluid/Values/StringValue.cs @@ -70,7 +70,7 @@ public static StringValue Create(string s) [MethodImpl(MethodImplOptions.AggressiveInlining)] public static StringValue Create(string s, bool encode) { - return Create(s, encode); + return new StringValue(s, encode); } [MethodImpl(MethodImplOptions.AggressiveInlining)] @@ -93,7 +93,7 @@ public override bool Equals(FluidValue other) return _value == other.ToStringValue(); } - // Delegating other types + // Delegating other types if (other == BlankValue.Instance || other == NilValue.Instance || other == EmptyValue.Instance) { return other.Equals(this);