Silenced E_DEPRECATED errors are reported

[kukulich]

Q	A
PHPUnit version	10.0.4
PHP version	8.2.2
Installation Method	Composer

Summary

Silenced deprecated errors are reported.

Current behavior

In BetterReflection is this code:

// @ because access to deprecated constant throws deprecated warning
$constantValue           = @constant($constantName);

Since PHPUnit 10 the deprecated errors are reported:

....................DDD.DDDD.DDD.DD.DDD.DD.DDDDDDDDDDDD.DDD 10030 / 13001 ( 77%)
.DDDDDDDDDDDD.DDDDDDDDDD..DD.DD.DDDDD.DDDDDD.DDDD.DDDDDDDDD 10089 / 13001 ( 77%)
DDDDDDDDDD..DDD.DDD.D..DDDDDDD.DDDDDDDDD..DDD.DD.D...DD.DDD 10148 / 13001 ( 78%)
DDD.DDDDDDDD.DD.DDDDDDDDDDD.DDDDDDD.DDDDD.DD.DDDD.DDDDDD..D 10207 / 13001 ( 78%)

Tests: 13001, Assertions: 73217, Deprecations: 398, Skipped: 5.

See https://github.com/Roave/BetterReflection/actions/runs/4107910137/jobs/7087976443

With --display-deprecations

304) Roave\BetterReflectionTest\SourceLocator\SourceStubber\PhpStormStubsSourceStubberTest::testConstantInPhpVersion with data set #4
* Constant FILTER_SANITIZE_STRING is deprecated

* Constant FILTER_SANITIZE_STRIPPED is deprecated

better-reflection\test\unit\SourceLocator\SourceStubber\PhpStormStubsSourceStubberTest.php:950

305) Roave\BetterReflectionTest\SourceLocator\SourceStubber\PhpStormStubsSourceStubberTest::testConstantInPhpVersion with data set #2
* Constant FILTER_SANITIZE_STRING is deprecated

* Constant FILTER_SANITIZE_STRIPPED is deprecated

better-reflection\test\unit\SourceLocator\SourceStubber\PhpStormStubsSourceStubberTest.php:950

306) Roave\BetterReflectionTest\SourceLocator\SourceStubber\PhpStormStubsSourceStubberTest::testConstantInPhpVersion with data set #3
* Constant FILTER_SANITIZE_STRING is deprecated

* Constant FILTER_SANITIZE_STRIPPED is deprecated

better-reflection\test\unit\SourceLocator\SourceStubber\PhpStormStubsSourceStubberTest.php:950

It also looks the same error is reported many times.

How to reproduce

Roave/BetterReflection#1326

Eg.

vendor\bin\phpunit test\unit\SourceLocator\SourceStubber\PhpStormStubsSourceStubberTest.php --display-deprecations

Expected behavior

No D in progressbar and no deprecations reported.

[sebastianbergmann]

@kukulich Thank you for reporting this! What do you think about #5177?

[kukulich]

Thank you for the quick fix! #5177 may be useful - however I don't currently see any use-case for me :)