Annotations for ignoring code from code coverage are unintentionally ignored by default

[kukulich]

Q	A
PHPUnit version	9.0.0
PHP version	7.4.2
Installation Method	Composer

Summary

@codeCoverageIgnoreStart annotation does not work.

Current behavior

How to reproduce

https://github.com/slevomat/coding-standard/blob/master/SlevomatCodingStandard/Helpers/TypeHelper.php#L24

Expected behavior

The ignored line should not be marked as not covered.

[sebastianbergmann]

PHPUnit is not responsible for handling the @codeCoverageIgnoreStart etc. annotations, this component is. That is why I transferred the issue here.

[sebastianbergmann]

The code in this component that handles the @codeCoverageIgnoreStart annotation, https://github.com/sebastianbergmann/php-code-coverage/blob/8.0.0/src/CodeCoverage.php#L704 and https://github.com/sebastianbergmann/php-code-coverage/blob/8.0.0/src/CodeCoverage.php#L705, was not changed since the previous release.

[sebastianbergmann]

I also do not see any changes in php-token-stream which is the component that yields the value of $_token which https://github.com/sebastianbergmann/php-code-coverage/blob/8.0.0/src/CodeCoverage.php#L704 and https://github.com/sebastianbergmann/php-code-coverage/blob/8.0.0/src/CodeCoverage.php#L705 look at.

[kukulich]

With PHPUnit 8.5.2

[sebastianbergmann]

I believe you :-) I am able to reproduce the issue. And I may have just found the root cause.

[sebastianbergmann]

This is a bug in PHPUnit itself after all: due to a mistake I made while working on #3914, the processing of annotations such as @codeCoverageIgnoreStart is ignored by default in PHPUnit 9.0.0.

[curry684]

Funny how I just ran into this to find it fixed 3 hours ago :)

However - 'ignored by default' implies I should be able to fix it by adding disableCodeCoverageIgnore="false" to the phpunit.xml, but that doesn't change a thing. Don't you mean they are always ignored, not just by default?