Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception type declarations in TestListener #2566

Closed
kelunik opened this issue Mar 12, 2017 · 0 comments
Closed

Exception type declarations in TestListener #2566

kelunik opened this issue Mar 12, 2017 · 0 comments
Labels
type/backward-compatibility Something will be/is intentionally broken
Milestone
PHPUnit 7.0

Comments

@kelunik
Copy link
Contributor

kelunik commented Mar 12, 2017

Q A
PHPUnit version any
PHP version any
Installation Method irrelevant

PHPUnit\Framework\TestListener / PHPUnit_Framework_TestListener contains exception type declarations which are not compatible with PHP 7's Throwable.

Unfortunately they cannot be dropped, as doing so would case a BC break. This is a tracking issue for PHPUnit 7.0 therefore.

I didn't investigate what happens on a Throwable occurring. A mitigation could be to introduce separate methods for Throwables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/backward-compatibility Something will be/is intentionally broken
Projects
None yet
Milestone
PHPUnit 7.0
Development

No branches or pull requests
2 participants
@sebastianbergmann @kelunik