Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests stop on php notices when running under HHVM in php7 compatibility mode #2278

Closed
photodude opened this issue Aug 28, 2016 · 2 comments
Closed

Comments

@photodude
Copy link

Running php unit under HHVM in php7 compatibility mode I'm having the tests halt on cases where phpunit runs into php4 style constructors with the error Methods with the same name as their class will not be constructors in a future version of PHP

This issue does not happen with testing under PHP7, just when testing under HHVM in PHP7 mode
I've heard that the tests might be halting because "PHPUnit converts notices to exceptions." and that's somehow killing the tests, but I'm not sure if that is accurate.

@sebastianbergmann
Copy link
Owner

Sounds like an issue with HHVM to me. And, to be honest, I do not care about HHVM anymore.

@photodude
Copy link
Author

photodude commented Aug 28, 2016

Sorry to hear that you no longer care about HHVM as a platform for PHPunit to support. That may kill HHVM for our projects since we will no longer have a unit testing option to validate with.

Is there anything specific that has pushed you to move on from HHVM?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants