Fix problem of --stderr with --tap or --testdox options
#1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| isset($this->arguments['verbose']) ? $this->arguments['verbose'] : false | ||
| ); | ||
| if (isset($phpunit['stderr']) && ! isset($this->arguments['stderr'])) { | ||
| $this->arguments['stderr'] = $phpunit['stderr']; |
There was a problem hiding this comment.
Can we merge the arguments with the settings from the configuration file? Like:
$this->arguments = $this->arguments + $phpunit;
henriquemoody
changed the title
--stderr with --tap and/or --testdox--stderr with --tap or --testdox options
sebastianbergmann
added a commit
that referenced
this pull request
Dec 22, 2014
Fix problem of `--stderr` with `--tap` or `--testdox` options
|
Alright, cherry-picked into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this pull request is the best solution to fix #1455, but I'm sure it solves the problem.
Actually, the main problem, IMO, is because there is no centralized point to create printers instances.
PHPUnit_TextUI_Commandcreates and configures printers objects butPHPUnit_TextUI_TestRunnertoo.I will be glad to create a Factory for these printers but it requires a quite of change.
PS.: I can not test this, because seems that PHPT does not recognize STDERR.