Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML CodeCoverage doesn't sort files/dirs anymore #803

Closed
Slamdunk opened this issue Aug 28, 2020 · 3 comments · Fixed by #804
Closed

HTML CodeCoverage doesn't sort files/dirs anymore #803

Slamdunk opened this issue Aug 28, 2020 · 3 comments · Fixed by #804

Comments

@Slamdunk
Copy link
Contributor

Slamdunk commented Aug 28, 2020 •
edited
Loading

Q A
php-code-coverage version 9.1.5
PHP version 7.4.9
Driver PCOV
Installation Method Composer
Usage Method PHPUnit
PHPUnit version (if used) 9.3.8
Until 9.1.4 9.1.5
image image
@sebastianbergmann
Copy link
Owner

There is no obvious change in 9.1.4...9.1.5 that would explain this. TBH, I do not remember that there ever was an explicit sorting in place for this.

@sebastianbergmann
Copy link
Owner

@dvdoug Could this be related to #801 and 7e91099, too, somehow?

@dvdoug
Copy link
Contributor

dvdoug commented Aug 28, 2020

If the files in the filter list are naturally alphabetical from the directory iteration, then it makes sense that the covered files list may have been previously been initialised as an alphabetical list due to preloading.

@dvdoug dvdoug mentioned this issue Aug 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Explicitly sort file list dvdoug/php-code-coverage
3 participants
@sebastianbergmann @Slamdunk @dvdoug