PHPStan Rule Level 5 error in src/Data/ProcessedCodeCoverageData.php

[sebastianbergmann]

The "only" errors left (after reapplying 60fe3d7 which was reverted in 48b98da) before we can go to PHPStan Rule Level 5 for #1039 are these:

 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   src/Data/ProcessedCodeCoverageData.php                                                                                                                                                                                                                                                                                                                                           
 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  195    Parameter #3 $functionData of method SebastianBergmann\CodeCoverage\Data\ProcessedCodeCoverageData::initPreviouslySeenFunction() expects array{branches: array<int, array{op_start: int, op_end: int, line_start: int, line_end: int, hit: int, out: array<int, int>, out_hit: array<int, int>}>, paths: array<int, array{path: array<int, int>, hit: int}>}, array{branches:    
         array<int, array{op_start: int, op_end: int, line_start: int, line_end: int, hit: list<string>, out: array<int, int>, out_hit: array<int, int>}>, paths: array<int, array{path: array<int, int>, hit: list<string>}>, hit: list<string>} given.                                                                                                                                  
         🪪  argument.type                                                                                                                                                                                                                                                                                                                                                                
         💡 Offset 'branches' (array<int, array{op_start: int, op_end: int, line_start: int, line_end: int, hit: int, out: array<int, int>, out_hit: array<int, int>}>) does not accept type array<int, array{op_start: int, op_end: int, line_start: int, line_end: int, hit: list<string>, out: array<int, int>, out_hit: array<int, int>}>: Offset 'hit' (int) does not accept type    
            list<string>.                                                                                                                                                                                                                                                                                                                                                                 
  197    Parameter #3 $functionData of method SebastianBergmann\CodeCoverage\Data\ProcessedCodeCoverageData::initPreviouslyUnseenFunction() expects array{branches: array<int, array{op_start: int, op_end: int, line_start: int, line_end: int, hit: int, out: array<int, int>, out_hit: array<int, int>}>, paths: array<int, array{path: array<int, int>, hit: int}>}, array{branches:  
         array<int, array{op_start: int, op_end: int, line_start: int, line_end: int, hit: list<string>, out: array<int, int>, out_hit: array<int, int>}>, paths: array<int, array{path: array<int, int>, hit: list<string>}>, hit: list<string>} given.                                                                                                                                  
         🪪  argument.type                                                                                                                                                                                                                                                                                                                                                                
         💡 Offset 'branches' (array<int, array{op_start: int, op_end: int, line_start: int, line_end: int, hit: int, out: array<int, int>, out_hit: array<int, int>}>) does not accept type array<int, array{op_start: int, op_end: int, line_start: int, line_end: int, hit: list<string>, out: array<int, int>, out_hit: array<int, int>}>: Offset 'hit' (int) does not accept type    
            list<string>.                                                                                                                                                                                                                                                                                                                                                                 
 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 

However, I cannot seem to see the forest for the trees at the moment. May I bother you, @staabm, to have a look? Thanks!

[staabm]

I think the problem is that hit: list<TestIdType>,

php-code-coverage/src/Data/ProcessedCodeCoverageData.php

Line 50 in 48b98da

* hit: list<TestIdType>,

is not compatible with hit: int,

php-code-coverage/src/Driver/XdebugDriver.php

Line 43 in 48b98da

* hit: int,

when passing functionData into initPreviouslySeenFunction in

php-code-coverage/src/Data/ProcessedCodeCoverageData.php

Line 78 in 48b98da

$this->initPreviouslySeenFunction($file, $functionName, $functionData);

[staabm]

looking deeper now

[staabm]

I think PHPStan is right that you are passing the wrong array into the initPreviously function calls

php-code-coverage/src/Data/ProcessedCodeCoverageData.php

Lines 194 to 198 in 48b98da

	if (isset($this->functionCoverage[$file][$functionName])) {
	$this->initPreviouslySeenFunction($file, $functionName, $functionData);
	} else {
	$this->initPreviouslyUnseenFunction($file, $functionName, $functionData);
	}

the initPreviously* calls expect a hit: int but you pass in a hit: list<string> (at least if the types are declared correctly)