Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix s10: Multiple direct images per orbit for multiple visits #33

Open
K-Angelique-Kahle opened this issue Oct 28, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@K-Angelique-Kahle
Copy link

I currently have the pleasure to analyze data for multiple visits with multiple direct images per orbit. In s10, this triggers the "third case" in di_reformat in util.py.
The current version of pacman fails to correctly transfer the data stored in xrefyref.txt to meta.refpix, because the masking of orbits is not done correctly. To fix this, change line 267 in util.py from
mask_i = reffile['iorbit'] == i
to
mask_i = reffile['iorbit_cumul'] == i

I assume the current version will work if you only analyze one visit.

@sebastian-zieba
Copy link
Owner

Thanks Angelique! I'll make a PR for that.

@sebastian-zieba sebastian-zieba added the bug Something isn't working label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants