Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What are the supported Ruby version on the ruby_parser? #298

Closed
DamirSvrtan opened this issue Oct 6, 2019 · 5 comments
Closed

What are the supported Ruby version on the ruby_parser? #298

DamirSvrtan opened this issue Oct 6, 2019 · 5 comments
Assignees

Comments

@DamirSvrtan
Copy link

DamirSvrtan commented Oct 6, 2019

Hi! 👋 I was wondering what were the supported versions of Ruby for the ruby_parser project?

The fasterer project depends on the Ruby parser and the travis CI build has been failing on ruby versions 1.9.3 and 2.0.0 since the latest version of the ruby parser gem 3.14.0.

I saw in the history file that there is some drop of support for 1.8.x and 1.9.x., but i was wondering if there's somewhere where I could find out explicitly which versions are supported?

To be clear, I have no issues dropping support for those older versions. Btw the errors can be seen here.

@zenspider
Copy link
Member

I dropped 1.8 and 1.9 for parsing and put them in the ruby_parser-legacy gem. You can add that dependency, require it, and they should work again.

As far as runtime goes, yeah. I've only been testing against ruby 2.4 and up (the supported ruby lines) but recently that caused problems with my minitest gem and had to go back down to 2.2. For to_h errors you'd definitely need a ruby 2.1 and higher. I'll add metadata to the gem to be more explicit.

@DamirSvrtan
Copy link
Author

Thanks @zenspider, adding metadata would be great! Thanks for the detailed explanation! Lemme know when it's done or I can open a PR as well - whatever's easier for you!

@zenspider
Copy link
Member

All done. Just not released yet.

@zenspider
Copy link
Member

Released

@DamirSvrtan
Copy link
Author

Thanks @zenspider!

@seattlerb seattlerb locked and limited conversation to collaborators Jan 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants