Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature : add TC exception log appender metric #5396

Merged
merged 8 commits into from
Mar 2, 2023

Conversation

Bughue
Copy link
Contributor

@Bughue Bughue commented Feb 28, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

新增logback的appender,appender并不会直接上报metric,只负责触发event。由metricsubscribe统一上报。

Ⅱ. Does this pull request fix one issue?

fixes #4586

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, add change in 2.0.0.md

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023

Codecov Report

Merging #5396 (cb084c9) into 2.x (86c1c5d) will decrease coverage by 0.01%.
The diff coverage is 14.28%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5396      +/-   ##
============================================
- Coverage     48.75%   48.75%   -0.01%     
- Complexity     4337     4340       +3     
============================================
  Files           776      778       +2     
  Lines         27432    27454      +22     
  Branches       3410     3412       +2     
============================================
+ Hits          13375    13384       +9     
- Misses        12661    12674      +13     
  Partials       1396     1396              
Impacted Files Coverage Δ
.../main/java/io/seata/core/event/ExceptionEvent.java 0.00% <0.00%> (ø)
...ogging/logback/appender/MetricLogbackAppender.java 0.00% <0.00%> (ø)
...ava/io/seata/server/metrics/MetricsSubscriber.java 28.81% <0.00%> (-0.76%) ⬇️
...java/io/seata/server/metrics/MeterIdConstants.java 100.00% <100.00%> (ø)
...er/src/main/java/io/seata/server/ServerRunner.java 50.00% <0.00%> (ø)
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.76% <0.00%> (+0.73%) ⬆️
...rage/redis/store/RedisTransactionStoreManager.java 77.89% <0.00%> (+1.28%) ⬆️

@Bughue
Copy link
Contributor Author

Bughue commented Mar 1, 2023

LGTM, add change in 2.0.0.md

done

@slievrly slievrly changed the title feature : TC log appender metric feature : add TC exception log appender metric Mar 2, 2023
@slievrly slievrly merged commit e69627d into apache:2.x Mar 2, 2023
@slievrly slievrly added this to the 2.0.0 milestone Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metric for exception in log output(TC)
3 participants