-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature : add TC exception log appender metric #5396
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, add change in 2.0.0.md
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #5396 +/- ##
============================================
- Coverage 48.75% 48.75% -0.01%
- Complexity 4337 4340 +3
============================================
Files 776 778 +2
Lines 27432 27454 +22
Branches 3410 3412 +2
============================================
+ Hits 13375 13384 +9
- Misses 12661 12674 +13
Partials 1396 1396
|
done |
Ⅰ. Describe what this PR did
新增logback的appender,appender并不会直接上报metric,只负责触发event。由metricsubscribe统一上报。
Ⅱ. Does this pull request fix one issue?
fixes #4586
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews