bugfix: the redis lock key and the session key has conflict #3148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3148 +/- ##
=============================================
- Coverage 50.46% 50.33% -0.13%
Complexity 3110 3110
=============================================
Files 593 593
Lines 19571 19570 -1
Branches 2427 2396 -31
=============================================
- Hits 9876 9851 -25
Misses 8702 8702
- Partials 993 1017 +24 |
lightClouds917
changed the title
l81893521
changed the title
Closed
1 task
l81893521
pushed a commit
to l81893521/seata
that referenced
this pull request
Oct 22, 2020
hicf
pushed a commit
to hicf/seata
that referenced
this pull request
Nov 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
the lock has this key,it is a name of hash:
private static final String DEFAULT_REDIS_SEATA_GLOBAL_LOCK_PREFIX = "SEATA_GLOBAL_LOCK";the session has this key,it is a name of string:
private static final String DEFAULT_REDIS_SEATA_GLOBAL_PREFIX = "SEATA_GLOBAL_";They have the same prefix :SEATA_GLOBAL_ ，the
RedisTransactionStoreManager# public List<GlobalSession> readSession(GlobalStatus[] statuses),use theredis scanof key SEATA_GLOBAL_* to get(key).It will cause:
redis.clients.jedis.exceptions.JedisDataException: WRONGTYPE Operation against a key holding the wrong kind of value at redis.clients.jedis.Protocol.processError(Protocol.java:132) at redis.clients.jedis.Protocol.process(Protocol.java:166) at redis.clients.jedis.Protocol.read(Protocol.java:220) at redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:318) at redis.clients.jedis.Connection.getBinaryBulkReply(Connection.java:255) at redis.clients.jedis.Connection.getBulkReply(Connection.java:245) at redis.clients.jedis.Jedis.get(Jedis.java:181) at io.seata.server.storage.redis.store.RedisTransactionStoreManager.readSession(RedisTransactionStoreManager.java:230) at io.seata.server.storage.redis.store.RedisTransactionStoreManager.readSession(RedisTransactionStoreManager.java:290) at io.seata.server.storage.redis.session.RedisSessionManager.findGlobalSessions(RedisSessionManager.java:188) at io.seata.server.storage.redis.session.RedisSessionManager.allSessions(RedisSessionManager.java:178) at io.seata.server.coordinator.DefaultCoordinator.timeoutCheck(DefaultCoordinator.java:216) at io.seata.server.coordinator.DefaultCoordinator.lambda$init$20(DefaultCoordinator.java:404) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.runAndReset$$$capture(FutureTask.java:308) at java.util.concurrent.FutureTask.runAndReset(FutureTask.java) atⅡ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews