Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[in progress] Have done fail test with error #47

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[in progress] Have done fail test with error #47

wants to merge 2 commits into from

Conversation

neall
Copy link
Collaborator

@neall neall commented Aug 13, 2015

This asserts part of the functionality needed to fix #25

neall added 2 commits August 11, 2015 09:10
@neall
reverse unless/else condition to be an if/else
f140dd1
@neall
failing test for When's done called with an error
b9b0f57 
I think this test is failing for the right reason.

passing the "done" callback an error should make the test fail.
@searls
Copy link
Owner

searls commented Aug 14, 2015

Go, Neal, Go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When(done) not failing on callback error
2 participants
@neall @searls