Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Bring inline" #18

Open
jelmerdemaat opened this issue Sep 2, 2012 · 4 comments
Open

"Bring inline" #18

jelmerdemaat opened this issue Sep 2, 2012 · 4 comments

Comments

@jelmerdemaat
Copy link

Hi,

I just started using your email template and it gives some great advises (to me as a novice).
There is however a notion to "bring inline" certain styles, which confuses me.

Does this mean that, for example, you have to copy the standard styles for images to each instance of an image in the email?
And for each h1, h2, h3... table, and so on?
Or do I have to move the <style> block to be inside the ?

Either way, maybe the action to "bring inline" styles could be explained in more detail in the template?
It could be due to the fact that I'm a non-native English speaker as well.

Cheers,

Jelmer

@jelmerdemaat
Copy link
Author

I don't know why the HTML tags in the previous message appeared, but I guess the question is clear. :)

@cssagogo
Copy link

cssagogo commented Sep 6, 2012

No it is confusing. The documentation contains... "INLINE: Yes.", "Bring inline: Yes.", "Bring inline: No." and " Don't bring anything below this line inline." I'm not sure if each has its own meaning or if the same things are just being restated in different ways. I know what to do with the "Bring inline: Yes" stuff, but I don't know what to do with the rest. Should it be an embedded style sheet? If so should it be contained in the head or just inside the body?

@emilchristensen
Copy link
Contributor

The stuff that does not have "Bring inline: Yes" should just be left in the <style>-block in the head.

@rickpastoor
Copy link

Would be great to update the boilerplate template and straight this out. For example this part:

/* Some sensible defaults for images
1. "-ms-interpolation-mode: bicubic" works to help ie properly resize images in IE. (if you are resizing them using the width and height attributes)
2. "border:none" removes border when linking images.
3. Updated the common Gmail/Hotmail image display fix: Gmail and Hotmail unwantedly adds in an extra space below images when using non IE browsers. You may not always want all of your images to be block elements. Apply the "image_fix" class to any image you need to fix.

Bring inline: Yes.
*/
img {outline:none; text-decoration:none; -ms-interpolation-mode: bicubic;}
a img {border:none;}
.image_fix {display:block;}

Should I bring .image_fix inline? If so, why declare a class for it? Might be a better idea to add sample blocks of content to the body with all styles attached (for example a normal image, an image with a link, etc.)

Repository owner deleted a comment from Pappyskull1 Feb 23, 2024
Repository owner deleted a comment from technosoft-admin Mar 4, 2024
Repository owner deleted a comment from theHinneh Mar 4, 2024
Repository owner deleted a comment from renato71amorim Mar 4, 2024
@github-staff github-staff deleted a comment from maulanaayub May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants
@rickpastoor @emilchristensen @cssagogo @jelmerdemaat and others