Update to native-tls 0.2

[est31]

native-tls 0.2 brings in the openssl update from 0.9 to 0.10.

[FauxFaux]

This seems to depend on upgrading hyper-tls to 0.3, which Sean released yesterday.

(To save anyone else doing some of the work..)

[seanmonstar]

To get this into the 0.8.x branch, the code from tokio-tls and hyper-tls would need to be inlined into reqwest directly, since hyper-tls already expects hyper 0.12. I asked about the changes in native-tls, and it's mostly new features, so it seems best to just make this upgrade along with the hyper 0.12 upgrade, being part of reqwest 0.9.

[seanmonstar]

The upgrade to hyper 0.12 is done, so the next step here would be to just upgrade to hyper-tls v0.3.0, and then we'd be "done"!

[FauxFaux]

This still depends on: tokio-rs/tokio-tls#43 , without it,

reqwest/src/connect.rs

Line 72 in c1c5f14

tls.connect_async(&host, tunneled)

's use of connect_async doesn't make sense.

Also, I suspect Connector#danger_disable_hostname_verification needs to go.

[seanmonstar]

hyper-tls 0.3 dropped the tokio-tls dependency, so we're not blocked. The danger method can customize the TlsConnector directly.

[FauxFaux]

I have no idea how to proceed. The code in hyper_tls seems to solve this issue by using hyper_tls::TlsStream(new: native_tls::TlsStream), which is pub(crate), so not accessible to us. I'm going to leave this one to the experts.

[seanmonstar]

@FauxFaux what issue exactly are you running into? Would you be able to push a diff somewhere?

[sbditto85]

I have a branch that isn't ready to be merged if someone wants to check it. https://github.com/sbditto85/reqwest/tree/update_native_tls

the reason it isn't ready to be merged is i had to update tokio-tls and I'm not sure I updated it properly as I'm new to the ecosystem.

my updates to tokio-tls are found at https://github.com/sbditto85/tokio-tls/tree/update_native_tls and I basically commented out one of the functions as TlsConnector doesn't have it anymore.

Not sure the best way to proceed.

[seanmonstar]

Is there a reason tokio-tls is still needed? I don't think it should be required anymore...

[sbditto85]

used in src/connect.rs for tls.connect_async(&host, tunneled) on line 68 (the TlsConnectorExt trait)

not sure where else though

[seanmonstar]

Oh shoot, you're right, it's need to tunneled proxies. Gah, I'd rather not have a dependency on tokio-tls, since it's lagging behind (still depends on tokio-core) and probably won't get much attention...

Perhaps the connect_async that's used in hyper-tls can be exported publicly?

[sbditto85]

I hope your not asking me haha ... i have no idea how most of this works. Just figuring it out now :)

[mehcode]

Added my take of this at #313 (already did this last week and forgot to send a PR).

Pending tokio-rs/tokio-tls#43

[seanmonstar]

This was done in #325!