Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #553 by adding :not-between #554

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Fixes #553 by adding :not-between #554

merged 1 commit into from
Nov 22, 2024

Conversation

plooney81
Copy link
Contributor

@plooney81 plooney81 commented Nov 22, 2024 •
edited
Loading

Extends special syntax to include NOT BETWEEN:

(sql/format-expr [:not-between :id 1 100])
;;=> ["id NOT BETWEEN ? AND ?" 1 100]

seancorfield
seancorfield requested changes Nov 22, 2024
View reviewed changes
src/honey/sql.cljc Outdated Show resolved Hide resolved
seancorfield
seancorfield approved these changes Nov 22, 2024
View reviewed changes
Copy link
Owner

@seancorfield seancorfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! And thank you for adding documentation (which also runs as a test).

@seancorfield seancorfield merged commit 488ddd4 into seancorfield:develop Nov 22, 2024
5 checks passed
seancorfield added a commit that referenced this pull request Nov 22, 2024
@seancorfield
add #553 / #554 to change log
c0c4553 
Signed-off-by: Sean Corfield <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seancorfield seancorfield seancorfield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plooney81 @seancorfield