First call to format with :dialect may fail

[valerauko]

user=> (honey.sql/format
  {:replace-into :accounts
   :values [{:public-key 1 :private-key 2}]
   :returning [:*]})
ExceptionInfo These SQL clauses are unknown or have nil values: :replace-into {:replace-into :accounts}
user=> (honey.sql/format
  {:replace-into :accounts
   :values [{:public-key 1 :private-key 2}]
   :returning [:*]}
  {:dialect :mysql
   :quoted-kebab true})
ExceptionInfo These SQL clauses are unknown or have nil values: :replace-into {:replace-into :accounts}

Then from the next call on it'd succeed.

user=> (honey.sql/format
  {:replace-into :accounts
   :values [{:public-key 1 :private-key 2}]
   :returning [:*]}
  {:dialect :mysql
   :quoted-kebab true})
["REPLACE INTO `accounts` (`public-key`, `private-key`) VALUES (?, ?) RETURNING *" 1 2]
user=> (honey.sql/format
  {:replace-into :accounts
   :values [{:public-key 1 :private-key 2}]
   :returning [:*]})
["REPLACE INTO accounts (public_key, private_key) VALUES (?, ?) RETURNING *" 1 2]

honeysql/src/honey/sql.cljc

Lines 107 to 110 in 23be700

	:clause-order-fn
	#(do
	(register-clause! :replace-into :insert-into :insert-into)
	(add-clause-before % :set :where))}

Maybe the :clause-order-fn is called at the wrong time and/or the clause dictionary is deref'd before it so it's not updated for the first call?

Workaround

• using set-dialect! before any format calls
• not using :mysql

[seancorfield]

Your deduction of the bug is spot on: the argument to :clause-order-fn is the base clause order so it has already been derefed and passed in before register-clause! does its thing.

[valerauko]

Thanks for the blazing fast fix! <3

[seancorfield]

Let me know if it actually solves the problem for you without introducing any new problems! There should be a new SNAPSHOT you can depend on from Clojars or you can test against git deps.

[valerauko]

I can confirm the first call to format with :dialect now works! (And I don't see anything breaking.) Thanks!