Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow with expr AS ident syntax in WITH clause #432

Merged

Conversation

MawiraIke
Copy link
Contributor

This is to allow for ClickHouse WITH clause variants.
See #428

@seancorfield
Copy link
Owner

This still has references to ClickHouse. It should not. It also has no tests and no documentation updates. It also makes gratuitous indentation/whitespace changes.

It should be based purely on the types of the two parts of the WITH clause (whether they are ident?).

If you want to submit an updated PR with the above changes, feel free, but I'm happy to fix #433 myself when I get some time.

@MawiraIke
Copy link
Contributor Author

MawiraIke commented Sep 22, 2022

Okay, let me push an updated PR. I assumed you might have wanted to retain the current functionality for existing dialects. I.e throwing an error when the expression is not a subquery expression since the syntax is not supported anyway. I am updating the code to change the syntax if the expr is ident?

@MawiraIke
Copy link
Contributor Author

MawiraIke commented Sep 23, 2022

@seancorfield I have updated the code with the suggested changes. I am available to make any further changes.
Also, I could not base it on ident? only and had to had string? because there is no simpler way to represent strings with spaces without further code changes.

@seancorfield
Copy link
Owner

Thanks. I've kicked off a CI run and if it passes, I'll merge this in. Much appreciated!

@seancorfield seancorfield merged commit 9a03dde into seancorfield:develop Sep 23, 2022
seancorfield added a commit that referenced this pull request Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants