You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Now that the default behavior of namespace-qualified keywords has been restored to the pre-0.9.0 behavior, it would probably make sense to introduce a new option to treat such keywords as :table.column which would be a better map for dealing with next.jdbc and libraries like seql.
So there would be three behaviors:
default: turn :table/column into just column -- the behavior in 0.9.7 and prior to 0.9.0,
:allow-namespaced-names? true: turn :table/column into table/column and assume the user knows what they're doing and is also quoting names (I think this is odd behavior but @jrdoane introduced it so I'll assume he -- and possibly others -- are relying on this),
(some new option): turn :table/column into table.column so namespace-qualified keys would become a first-class citizen and would round-trip as expected when using next.jdbc (and seql etc).
Note that next.jdbc.sql's behavior for namespace-qualified keys matches HoneySQL 0.9.7 (and pre-0.9.0): the namespace portion is simply discarded -- which makes sense for the very simple queries that it attempts to generate. next.jdbc's primary API traffics in SQL strings where it's up to the user to deal with aliases and table names etc.
I think a good name for the new option would be :namespace-as-table?
The text was updated successfully, but these errors were encountered:
Now that the default behavior of namespace-qualified keywords has been restored to the pre-0.9.0 behavior, it would probably make sense to introduce a new option to treat such keywords as
:table.column
which would be a better map for dealing withnext.jdbc
and libraries like seql.So there would be three behaviors:
:table/column
into justcolumn
-- the behavior in 0.9.7 and prior to 0.9.0,:allow-namespaced-names? true
: turn:table/column
intotable/column
and assume the user knows what they're doing and is also quoting names (I think this is odd behavior but @jrdoane introduced it so I'll assume he -- and possibly others -- are relying on this),:table/column
intotable.column
so namespace-qualified keys would become a first-class citizen and would round-trip as expected when usingnext.jdbc
(andseql
etc).Note that
next.jdbc.sql
's behavior for namespace-qualified keys matches HoneySQL 0.9.7 (and pre-0.9.0): the namespace portion is simply discarded -- which makes sense for the very simple queries that it attempts to generate.next.jdbc
's primary API traffics in SQL strings where it's up to the user to deal with aliases and table names etc.I think a good name for the new option would be
:namespace-as-table?
The text was updated successfully, but these errors were encountered: