Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libethdrivers: make zynqmp driver usable #161

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

axel-h
Copy link
Member

@axel-h axel-h commented May 25, 2023

  • fix compatibility string. Seems this changed in at some point in the device tree? Or did this ever work, because that seems the zynq7000 string?
  • add zynqmp driver to the list of symbols kept, so the linker will not throw this out.

@chrisguikema I'm a bit confused actually, how do things work for you without these changes?

Copy link
Contributor

@abrandnewusername abrandnewusername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me.

@chrisguikema
Copy link
Contributor

@axel-h Long story short, a lot of our customers require us to OPSEC each commit we want to open-source, which takes a long time. The two commits we released were ones we had approval for, and we've been using the zynqmp ethdrivers way before the driver framework was released. The goal was to have another series of commits made available that make the zynqmp usable, with an example platform, but the OPSEC process is taking a lot longer than anticipated

@axel-h
Copy link
Member Author

axel-h commented Feb 29, 2024

Can we merge this or is something blocking this still?

libethdrivers/CMakeLists.txt Show resolved Hide resolved
Axel Heider and others added 2 commits March 4, 2024 20:09
Co-authored-by: Sebastian Eckl <[email protected]>
Signed-off-by: Axel Heider <[email protected]>
Co-authored-by: Sebastian Eckl <[email protected]>
Signed-off-by: Axel Heider <[email protected]>
@Indanz Indanz merged commit b8f2a8e into seL4:master Mar 4, 2024
27 checks passed
@axel-h axel-h deleted the patch-axel-18 branch March 4, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hw-build all sel4test hardware builds
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants