basic foundation CI setup #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsf37
force-pushed
the
foundation-setup
branch
from
2e86278 to
bb02744
Compare
These are: gitlint, trailing whitespace check, portable shell check, style check, license check, and link check Signed-off-by: Gerwin Klein <[email protected]>
Signed-off-by: Gerwin Klein <[email protected]>
lsf37
force-pushed
the
foundation-setup
branch
from
bb02744 to
4d79cc2
Compare
Ivan-Velickovic
approved these changes
Sep 13, 2023
|
Only comment I have is that somewhere in the repository, it should show you how to run the checks yourself. E.g a README in |
|
For the CI tests I was going to add a |
That's a good idea, and we should probably add general instructions on how to run those checks somewhere central as well (and maybe then link from here or something like that). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the basic standard checks for foundation repos:
It also adds missing license headers and texts so that the licence check can succeed on new pull requests.
The style check is likely to fail initially if the repo hasn't used the same
astyleconfig before. We can leave that check as optional for a while of that leads to friction.