Fix linking of tool on Linux AArch64 #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I specified the linker to `aarch64-none-elf-ld` because I would've thought that even though we are targeting Linux, the linker shouldn't matter but on Linux AArch64 we get a segfault when running the Microkit tool. Changing the linker to `aarch64-linux-gnu-ld` fixes that. I'm not really happy with this solution as we now have to install a new C toolchain just to compile a Rust program, from searching on the internet the solution seems to be to use the cross-rs package, which just uses Docker containers so isn't actually cross compiling anything. If anyone has any better ideas please let me know. Signed-off-by: Ivan Velickovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I specified the linker to
aarch64-none-elf-ldbecause I would've thought that even though we are targeting Linux, the linker shouldn't matter but on Linux AArch64 we get a segfault when running the Microkit tool.Changing the linker to
aarch64-linux-gnu-ldfixes that.I'm not really happy with this solution as we now have to install a new C toolchain just to compile a Rust program, from searching on the internet the solution seems to be to use the cross-rs package, which just uses Docker containers so isn't actually cross compiling anything.
If anyone has any better ideas please let me know.