Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation check that primary_key, alternate_keys and sequence_key cannot be sdtype categorical #963

Closed
npatki opened this issue Aug 18, 2022 · 0 comments
Assignees
Labels
feature request Request for a new feature
Milestone

Comments

@npatki
Copy link
Contributor

npatki commented Aug 18, 2022

Problem Description

The initial version of SDV 1.0 will not support the case where primary key, alternate keys or sequence key are type categorical. Let's check for those cases during the metadata validation.

Expected Error

# primary key case
Error: The primary_key ('user_id') cannot be type 'categorical'.

# alternate keys
Error: The alternate_keys ('email', 'phone_number') cannot be type 'categorical'

# sequence keys
Error: The sequence_key ('patient_id') cannot be type 'categorical')

Additional context

Relevant methods to check are:

  • validate()
  • set_primary_key()
  • add_alternate_keys()
  • set_sequence_key()
@npatki npatki added the feature request Request for a new feature label Aug 18, 2022
@npatki npatki added this to the 1.0.0 milestone Aug 18, 2022
@fealho fealho mentioned this issue Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

3 participants