Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move table_data.copy to base class of constraints #845

Closed
fealho opened this issue Jun 17, 2022 · 1 comment · Fixed by #849
Closed

Move table_data.copy to base class of constraints #845

fealho opened this issue Jun 17, 2022 · 1 comment · Fixed by #849
Milestone
0.16.0

Comments

@fealho
Copy link
Member

fealho commented Jun 17, 2022 •
edited
Loading

It seems every constraint copies the table data in both the transform and reverse transform. Instead of doing that for every constraint, maybe we should just do it in the base class instead.
@amontanez24
@amontanez24
Copy link
Contributor

Yes, I completely agree we should do this

@fealho fealho mentioned this issue Jun 17, 2022
Merged
@pvk-developer pvk-developer added this to the 0.16.0 milestone Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.16.0
Development

Successfully merging a pull request may close this issue.

Move data.copy to base class of constraints sdv-dev/SDV
3 participants
@amontanez24 @fealho @pvk-developer