You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As a user, it would be useful if I could define range or inequality constraints without having to depend on reject sampling.
Expected behavior
Currently, the strict parameter in the range and inequality constraints can only be enforced using reject sampling. It is not guaranteed to work when set to True if the handling_strategy is set to transform.
Improve both constraints to support the strict parameter being set to True when using the transform strategy.
Problem Description
As a user, it would be useful if I could define range or inequality constraints without having to depend on reject sampling.
Expected behavior
Currently, the
strict
parameter in the range and inequality constraints can only be enforced using reject sampling. It is not guaranteed to work when set toTrue
if thehandling_strategy
is set totransform
.strict
parameter being set toTrue
when using thetransform
strategy.Additional context
strict
parameter is only used to set theoperator
parameter. This is only used in theis_valid
method which is only used to validate and duringreject_sampling
:https://github.com/sdv-dev/SDV/blob/master/sdv/constraints/tabular.py#L368-L371
https://github.com/sdv-dev/SDV/blob/master/sdv/constraints/tabular.py#L454
https://github.com/sdv-dev/SDV/blob/master/sdv/constraints/tabular.py#L741
https://github.com/sdv-dev/SDV/blob/master/sdv/constraints/tabular.py#L845-L849
strict
isTrue
The text was updated successfully, but these errors were encountered: