Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UniqueCombinations constraint for more than 2 columns #494

Closed
onacrame opened this issue Jul 1, 2021 · 2 comments · Fixed by #538
Closed

UniqueCombinations constraint for more than 2 columns #494

onacrame opened this issue Jul 1, 2021 · 2 comments · Fixed by #538
Assignees
Labels
bug Something isn't working
Milestone

Comments

@onacrame
Copy link

onacrame commented Jul 1, 2021

Environment Details

Please indicate the following details about the environment in which you found the bug:

  • SDV version: 0.10
  • Python version: 3.9
  • Operating System: Windows

Error Description

I was under the impression that adding a list of columns (more than 2) would constrain the model in respect of the combinations of categories represented by those columns but it does not seem to work. I see nulls generated where there should be none

Steps to reproduce

I can’t share my example due to privacy etc. but imagine that a toy example where a list of three categories passed to uniquecombinations would probably generate the same result.

@onacrame onacrame added bug Something isn't working pending review labels Jul 1, 2021
@tjhallum
Copy link

This issue of nan values being generated is NOT just limited to cases in which a UniqueCombinations constraint is applied to more than two columns. The generation of nan values likewise occurs when the UniqueCombinations constraint is applied to only two columns. A full reproducible example is provided in the form of a Jupyter Notebook attached to this issue: #521.

@csala csala closed this as completed in #538 Aug 2, 2021
@csala csala added this to the 0.12.0 milestone Aug 2, 2021
@csala
Copy link
Contributor

csala commented Aug 2, 2021

A full explanation of what caused this issue has been added in the PR that closed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants