Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support null foreign keys in get_random_subset #2056

Closed
gsheni opened this issue Jun 12, 2024 · 0 comments · Fixed by #2082
Closed

Support null foreign keys in get_random_subset #2056

gsheni opened this issue Jun 12, 2024 · 0 comments · Fixed by #2082
Assignees
Labels
feature request Request for a new feature
Milestone

Comments

@gsheni
Copy link
Contributor

gsheni commented Jun 12, 2024

Problem Description

  • Currently, get_random_subset raises a warning if it detects null foreign keys.
  • To support null foreign keys in SDV, we would like to remove this warning and change the behavior of get_random_subset to allow null foreign keys to be subsampled.

Expected behavior

  • A user can use get_random_subset with null foreign keys.
  • The user does not get an error or warning with null foreign keys.
  • The user can expect that subsampled data returned from get_random_subset may contain null foreign keys, if present in the input data.
@gsheni gsheni added the feature request Request for a new feature label Jun 12, 2024
@gsheni gsheni changed the title Change get_random_subset to support null foreign keys Allow null foreign keys to be passed in get_random_subset Jun 12, 2024
@gsheni gsheni changed the title Allow null foreign keys to be passed in get_random_subset Support null foreign keys in get_random_subset Jun 12, 2024
@R-Palazzo R-Palazzo self-assigned this Jun 20, 2024
@R-Palazzo R-Palazzo added this to the 1.14.1 milestone Jun 20, 2024
@amontanez24 amontanez24 modified the milestones: 1.15.0, 1.15.1 Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants