Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show an error if I accidentally load an SDV synthesizer on an older version of SDV #1837

Closed
npatki opened this issue Mar 5, 2024 · 2 comments · Fixed by #1873
Closed

Show an error if I accidentally load an SDV synthesizer on an older version of SDV #1837

npatki opened this issue Mar 5, 2024 · 2 comments · Fixed by #1873
Assignees
Labels
feature request Request for a new feature
Milestone

Comments

@npatki
Copy link
Contributor

npatki commented Mar 5, 2024

Problem Description

Consider the following scenario:

  1. I have been trying SDV for many months. I have multiple environments running with different SDV versions
  2. I train and save a synthesizer on the latest SDV version (1.10.0)
  3. Later, I accidentally re-load that synthesizer in an environment with an older version (eg. in my other environment with 1.9.0)
  4. Some features don't work and error out. It is difficult to debug why this is happening.

Note that in this case, it is expected that some features may error, as SDV does not offer forwards compatibility. That is to say, if you downgrade your SDV version (in step 3), there is no guarantee that anything will work.

Expected behavior

Create a new VersionError type and show this if I try to load any synthesizer in this scenario.

>>> synthesizer = HMASynthesizer.load('synthesizer.pkl')
VersionError: You are currently on SDV version 1.8.0 but this 
synthesizer was created on version 1.10.0. Downgrading your SDV version is not supported.

Additional context

Apply this error to all synthesizers (available to public and enterprise)

Note that the trained version is available under synthesizer.get_info() (the enterprise version may not be -- perhaps we should add this)

@npatki npatki added the feature request Request for a new feature label Mar 5, 2024
@Ng-ms
Copy link

Ng-ms commented Mar 21, 2024

this error is happing again even without changing the version of the trained and loaded synthizers both are on sdv 1.9.0

@npatki
Copy link
Contributor Author

npatki commented Mar 21, 2024

Hi @Ng-ms that sounds like a bug. Could you file a new issue for it? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants