Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get_available_demos tests #1247

Closed
fealho opened this issue Feb 8, 2023 · 0 comments
Closed

Update get_available_demos tests #1247

fealho opened this issue Feb 8, 2023 · 0 comments
Assignees
Labels
internal The issue doesn't change the API or functionality
Milestone

Comments

@fealho
Copy link
Member

fealho commented Feb 8, 2023

Version: SDV 1.0.0 (in progress)

Problem Description

Both test_get_available_demos_single_table and test_get_available_demos_multi_table depend on the exact datasets present in S3. Whenever new datasets are added, these tests crash.

Solution

Update both of these tests so they only validate that a few datasets were correctly fetched, instead of all of them.

@fealho fealho added the internal The issue doesn't change the API or functionality label Feb 8, 2023
@fealho fealho added this to the 1.0.0 milestone Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal The issue doesn't change the API or functionality
Projects
None yet
Development

No branches or pull requests

2 participants