Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. bug fixes for SDV 1.0.0 #1193

Closed
amontanez24 opened this issue Jan 27, 2023 · 0 comments
Closed

Misc. bug fixes for SDV 1.0.0 #1193

amontanez24 opened this issue Jan 27, 2023 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@amontanez24
Copy link
Contributor

Environment Details

Please indicate the following details about the environment in which you found the bug:

  • SDV version: 1.0.0.dev
  • Python version: Any
  • Operating System: Any

Error Description

The following changes should be made:

  1. If a float column has more than 14 decimals places, sometimes we are unable to round. This raises the following warning:
    usr/local/lib/python3.8/dist-packages/sdv/data_processing/numerical_formatter.py:72: UserWarning: No rounding scheme detected for column 'max(y_wgs84)'. Synthetic data will not be rounded.
    The warning can be overwhelming and there isn't anything the user can really do about it, so we should make it logger info statement instead.
  2. The default for the model_missing_values parameter is currently set to True when calling auto_assign_transformers. It should be False instead
  3. The synthesizer.load method should change the name of the path paramter to filepath
  4. The sample_conditions method should be renamed to sample_from_conditions
  5. The following methods should be added to the SingleTablePreset
    • get_metadata - Wrapper around the SingleTableSynthesizer.get_metadata method
    • get_parameters - Wrapper around the SingleTableSynthesizer.get_parameters method
@amontanez24 amontanez24 added the bug Something isn't working label Jan 27, 2023
@amontanez24 amontanez24 added this to the 1.0.0 milestone Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants