Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change set_alternate_keys to add_alternate_keys and add error handling #1029

Closed
amontanez24 opened this issue Sep 23, 2022 · 0 comments
Closed
Assignees
Labels
feature request Request for a new feature
Milestone

Comments

@amontanez24
Copy link
Contributor

Problem Description

There are two desired changes:

  1. Update set_alternate_keys to add_alternate_keys because it is possible to add to the existing set.
  2. Add error handling to ensure that a primary key cannot be an alternate key

Expected behavior

  • Rename set_alternate_keys to add_alternate_keys
  • Errors:
    • If the user tries to add a key to the alternate keys when it's already a primary key, raise an error (use one similar to what exists for sequence keys).
    • If the user sets a primary key when it in the alternate keys allow this but raise a warning saying that we will remove it from the alternate keys
      • Be sure to actually remove the keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

1 participant