diff --git a/sdmetrics/reports/base_report.py b/sdmetrics/reports/base_report.py index b58a1ca6..22bda03e 100644 --- a/sdmetrics/reports/base_report.py +++ b/sdmetrics/reports/base_report.py @@ -53,7 +53,7 @@ def _validate_metadata_matches_data(self, real_data, synthetic_data, metadata): ) raise ValueError(error_message) - def validate(self, real_data, synthetic_data, metadata): + def _validate(self, real_data, synthetic_data, metadata): """Validate the inputs. Args: @@ -129,7 +129,7 @@ def generate(self, real_data, synthetic_data, metadata, verbose=True): if not isinstance(metadata, dict): raise TypeError('The provided metadata is not a dictionary.') - self.validate(real_data, synthetic_data, metadata) + self._validate(real_data, synthetic_data, metadata) self.convert_datetimes(real_data, synthetic_data, metadata) self.report_info['generated_date'] = datetime.today().strftime('%Y-%m-%d') diff --git a/tests/unit/reports/test_base_report.py b/tests/unit/reports/test_base_report.py index 5076e86b..183649ac 100644 --- a/tests/unit/reports/test_base_report.py +++ b/tests/unit/reports/test_base_report.py @@ -85,8 +85,8 @@ def test__validate_metadata_matches_data_no_mismatch(self): # Run and Assert base_report._validate_metadata_matches_data(real_data, synthetic_data, metadata) - def test_validate(self): - """Test the ``validate`` method.""" + def test__validate(self): + """Test the ``_validate`` method.""" # Setup base_report = BaseReport() mock__validate_metadata_matches_data = Mock() @@ -110,7 +110,7 @@ def test_validate(self): } # Run - base_report.validate(real_data, synthetic_data, metadata) + base_report._validate(real_data, synthetic_data, metadata) # Assert mock__validate_metadata_matches_data.assert_called_once_with( @@ -236,7 +236,7 @@ def test_generate(self, version_mock, time_mock, datetime_mock): mock_validate = Mock() mock__print_results = Mock() base_report._print_results = mock__print_results - base_report.validate = mock_validate + base_report._validate = mock_validate base_report._properties['Property 1'] = Mock() base_report._properties['Property 1'].get_score.return_value = 1.0 base_report._properties['Property 2'] = Mock() @@ -295,7 +295,7 @@ def test_generate_multi_table_details(self, version_mock, time_mock, datetime_mo base_report = BaseReport() base_report._print_results = Mock() - base_report.validate = Mock() + base_report._validate = Mock() base_report.convert_datetimes = Mock() base_report._properties['Property 1'] = Mock() base_report._properties['Property 1'].get_score.return_value = 1.0