Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that every property score are index-free #583

Closed
R-Palazzo opened this issue Jun 7, 2024 · 0 comments · Fixed by #611
Closed

Check that every property score are index-free #583

R-Palazzo opened this issue Jun 7, 2024 · 0 comments · Fixed by #611
Assignees
Labels
feature request Request for a new feature
Milestone

Comments

@R-Palazzo
Copy link
Contributor

Problem Description

A property score, like a metric, should not depend on the index of the real and synthetic data. It should only depend on their column values. It would be nice to have some integration tests that check that this is the case for all our current properties (single and multi-table) as well as for future ones.

Expected behavior

Write a simple integration test where real and synthetic data are the same and only differ by their indexes. Check that the property score is 1.0. Apply this test to all the properties (keeping in mind that it should work for future ones also). In the case of some property scores not being 1.0:

  • Investigate if an easy fix could solve the issue
  • Otherwise, an easy fix would be to copy the data and reset the index at the beginning of any reports.
@R-Palazzo R-Palazzo added the feature request Request for a new feature label Jun 7, 2024
@R-Palazzo R-Palazzo changed the title Check that every property are index-free Check that every property score are index-free Jun 7, 2024
@R-Palazzo R-Palazzo self-assigned this Jul 24, 2024
@R-Palazzo R-Palazzo added this to the 0.15.0 milestone Jul 24, 2024
@R-Palazzo R-Palazzo modified the milestones: 0.15.0, 0.15.1 Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant