Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure binary classification targets are bool #33

Merged
merged 2 commits into from
Dec 28, 2020
Merged

Conversation

csala
Copy link
Contributor

@csala csala commented Dec 28, 2020

When a binary classification dataset which has a target column that is not boolean (so, instead of containing True/False or 0/1 it contains 2 possible categories represented by strings or numerical values other than 0 and 1), the BinaryClassification metrics fail to get a score.

This PR adds a preprocessing step that detects this situation and re-encodes the binary categorical target variable as a boolean array.

@csala csala added the internal The issue doesn't change the API or functionality label Dec 28, 2020
@csala csala self-assigned this Dec 28, 2020
@csala csala added this to the 0.1.1 milestone Dec 28, 2020
@csala csala merged commit 877aaf4 into master Dec 28, 2020
@csala csala deleted the binary-efficacy branch December 28, 2020 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal The issue doesn't change the API or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant