Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _set_fitted_parameters method to NullTransformer #827

Closed
frances-h opened this issue Jun 2, 2024 · 0 comments · Fixed by #834
Closed

Add _set_fitted_parameters method to NullTransformer #827

frances-h opened this issue Jun 2, 2024 · 0 comments · Fixed by #834
Assignees
Labels
internal The issue doesn't change the API or functionality
Milestone

Comments

@frances-h
Copy link
Contributor

frances-h commented Jun 2, 2024

Problem Description

We'd like to be able to get a transformer into a fitted state using known parameters instead of existing data. This would allow us to set up a transformer to be able to reverse transform without first having to fit it on real data.

Expected behavior

Add the method _set_fitted_parameters to the NullTransformer. When called, the provided arguments should be set on the transformer to get it into a 'fitted' state so that it can be used to reverse transform. After being called, a user should be able to call reverse_transform and have it work as expected.

def _set_fitted_parameters(self, null_percentage):

  • Args:
    • null_percentage [float]: The percentage of values that should be replaced with null values. Should be used to set self._null_percentage

This method should not return anything.

@frances-h frances-h changed the title Add set_fitted_parameters method to NullTransformer Add _set_fitted_parameters method to NullTransformer Jun 4, 2024
@frances-h frances-h self-assigned this Jun 6, 2024
@frances-h frances-h added this to the 1.12.1 milestone Jun 6, 2024
@amontanez24 amontanez24 modified the milestones: 1.12.1, 1.12.2 Jul 9, 2024
@amontanez24 amontanez24 added the internal The issue doesn't change the API or functionality label Jul 9, 2024
@amontanez24 amontanez24 changed the title Add _set_fitted_parameters method to NullTransformer Add _set_fitted_parameters method to NullTransformer Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal The issue doesn't change the API or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants