Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings not showing on update_transformers_by_sdtype #582

Closed
amontanez24 opened this issue Nov 17, 2022 · 0 comments · Fixed by #588
Closed

Warnings not showing on update_transformers_by_sdtype #582

amontanez24 opened this issue Nov 17, 2022 · 0 comments · Fixed by #588
Assignees
Labels
bug Something isn't working
Milestone

Comments

@amontanez24
Copy link
Contributor

Environment Details

Please indicate the following details about the environment in which you found the bug:

  • RDT version: Master branch
  • Python version: Any
  • Operating System: Any

Error Description

The warning messages that are supposed to show up in update_transformers_by_sdtype aren't showing up.

According to issue #540, we should show the following warning if the user uses the 'transformers' parameter:
Deprecation Warning: The 'transformer' parameter will no longer be supported in future versions of the RDT. Please use the 'transformer_name' and 'transformer_parameters' parameters instead.

We should also show the following warning if the user uses the 'transformers' parameter AND the new 'transformer_name' parameter:
Deprecation Warning: The 'transformer' parameter will no longer be supported in future versions of the RDT. Using the 'transformer_name' parameter instead.

Steps to reproduce

from rdt.transformers.numerical import FloatFormatter

ht.update_transformers_by_sdtype(
    sdtype='numerical',
    transformer=FloatFormatter(),
    transformer_name='FloatFormatter',
    transformer_parameters={
        'missing_value_replacement': 'mean',
        'enforce_min_max_values': True,
        'learn_rounding_scheme': True,
    }
)
@amontanez24 amontanez24 added the bug Something isn't working label Nov 17, 2022
@amontanez24 amontanez24 added this to the 1.3.0 milestone Nov 17, 2022
@amontanez24 amontanez24 self-assigned this Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant