Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect_initial_config isn't detecting sdtype "numerical" #449

Closed
npatki opened this issue Mar 23, 2022 · 0 comments
Closed

detect_initial_config isn't detecting sdtype "numerical" #449

npatki opened this issue Mar 23, 2022 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@npatki
Copy link
Contributor

npatki commented Mar 23, 2022

Environment Details

  • RDT version: 1.0.0 (dev branch)

Error Description

The detect_initial_config is currently assigning types of int and float.

In RDT 1.0.0, these types are deprecated. The detected sdtype should be numerical for both types of columns.

Steps to reproduce

from rdt import HyperTransformer
from rdt import get_demo

data = get_demo()

ht = HyperTransformer()
ht.detect_initial_config(data)

Output: note how age is detected as "integer" and dollars_spent is detected as "float"

Config:
{
    "sdtypes": {
        "last_login": "categorical",
        "email_optin": "boolean",
        "credit_card": "categorical",
        "age": "integer",
        "dollars_spent": "float"
    },
    "transformers": ...
}
@npatki npatki added the bug Something isn't working label Mar 23, 2022
@amontanez24 amontanez24 added this to the 1.0.0 milestone Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants