Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transformers that cannot work with missing values should automatically fill them in #442

Closed
npatki opened this issue Mar 18, 2022 · 0 comments
Closed

Transformers that cannot work with missing values should automatically fill them in #442

npatki opened this issue Mar 18, 2022 · 0 comments
Assignees
@amontanez24
Labels
feature request Request for a new feature
Milestone
1.0.0

Comments

@npatki
Copy link
Contributor

npatki commented Mar 18, 2022

Environment Details

  • RDT version: 1.0.0 (dev branch)

Error Description

Both the ClusterBasedNormalizer and GaussianNormalizer cannot work if there are missing values. Let's:

  • Hardcode missing_value_replacement='mean' because that is the only method we use internally for these transformers
  • Remove missing_value_replacement as a parameter for the end user
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amontanez24 amontanez24

Labels
feature request Request for a new feature
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@npatki @amontanez24