Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase scikit-learn dependency range #351

Closed
csala opened this issue Jan 7, 2022 · 0 comments · Fixed by #375
Closed

Increase scikit-learn dependency range #351

csala opened this issue Jan 7, 2022 · 0 comments · Fixed by #375
Assignees
@amontanez24
Labels
maintenance Task related to infrastructure & dependencies
Milestone
0.6.3

Comments

@csala
Copy link
Contributor

csala commented Jan 7, 2022 •
edited
Loading

PR #329 introduced a dependency on scikit-learn that was restricted to <1, forcing a downgrade of scikit-learn below 1 when using SDV.

We should increase the range to <2 to match the other libraries in the ecosystem.
@csala csala added the maintenance Task related to infrastructure & dependencies label Jan 7, 2022
@amontanez24 amontanez24 mentioned this issue Jan 27, 2022
Merged
@amontanez24 amontanez24 self-assigned this Jan 27, 2022
@amontanez24 amontanez24 added this to the 0.6.3 milestone Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amontanez24 amontanez24

Labels
maintenance Task related to infrastructure & dependencies
Projects
None yet
Milestone
0.6.3
Development

Successfully merging a pull request may close this issue.

Increase scikit-learn dependency range sdv-dev/RDT
2 participants
@csala @amontanez24