Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add performance-based testing #194

Closed
amontanez24 opened this issue Jul 20, 2021 · 2 comments · Fixed by #195
Closed

Add performance-based testing #194

amontanez24 opened this issue Jul 20, 2021 · 2 comments · Fixed by #195
Assignees
Labels
feature request Request for a new feature
Milestone

Comments

@amontanez24
Copy link
Contributor

amontanez24 commented Jul 20, 2021

We should add a way to test RDT transformers based on performance and resource usage by running the profiling function recently added and comparing the obtained results with some expected maximum time and memory usage.

The tests should be implemented as a single test module with a single test file that is parameterized with a collection of test cases found in configuration files written in JSON format.

Here would be the requirements of this:

  1. The test file should be in the module:
    tests/performance/test_performance.py.
  2. The test cases should be inside a tests/performance/test_cases folder.
  3. Test cases for each transformer can be put inside a folder dedicated to each one of them (e.g. tests/performance/test_cases/NumericalTransformer/<some_test_case>.json
  4. The test function should be parametrized with the config files found inside the test_cases folder.
  5. It should use the profile_transformer function on all the transformers and datasets defined by the config files
@amontanez24 amontanez24 added feature request Request for a new feature pending review and removed pending review labels Jul 20, 2021
@csala csala changed the title Add performance test file Add performance-based testing Jul 21, 2021
@csala
Copy link
Contributor

csala commented Jul 21, 2021

This sounds good @amontanez24
I updated a bit the description to add some more details and also match what you have already proposed in the corresponding PR.

@csala
Copy link
Contributor

csala commented Jul 21, 2021

@amontanez24 Maybe we should also add a few more things to this:

  1. Add a Makefile target (and tasks.py task) to run the performance tests alone
  2. Modify the invoke pytest task to run unit and integration tests only
  3. Add a specific check on the github workflow to run the performance tests on only one OS and python version, to prevent having multiple expected performances.

@fealho fealho added this to the 0.5.1 milestone Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants