Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use strict global danger #19

Open
mpchadwick opened this issue Dec 30, 2015 · 0 comments
Open

use strict global danger #19

mpchadwick opened this issue Dec 30, 2015 · 0 comments

Comments

@mpchadwick
Copy link
Member

ajaxaddtocart.js was converted to strict mode here

This is dangerous on a site that concatenates JS as it will effectively set the entire concatenated script to strict mode.

Setting use strict inside the IIFE seems like a safer choice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mpchadwick