Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported C++ standards to C++23 and C++20 (dropping C++17) #2053

Closed
wants to merge 1 commit into from
Closed

Update supported C++ standards to C++23 and C++20 (dropping C++17) #2053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ workflows:
matrix:
parameters:
compiler: ["clang++-17", "g++-13"]
standard: ["20", "17"]
standard: ["23", "20"]
mode: ["dev", "debug", "release"]
# only build this combination with dpdk enabled, so we don't double
# the size of the test matrix, and can at least test the build with
Expand All @@ -80,7 +80,7 @@ workflows:
matrix:
parameters:
compiler: ["clang++-17"]
standard: ["20"]
standard: ["23"]
mode: ["release"]
with_dpdk: [ "enable-dpdk" ]
# only build this combination with C++20 moduels enabled, so we don't double
Expand All @@ -90,6 +90,6 @@ workflows:
matrix:
parameters:
compiler: ["clang++-17"]
standard: ["20"]
standard: ["23"]
mode: ["debug"]
with_modules: [ "enable-modules" ]
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ set (CMAKE_CXX_FLAGS_SANITIZE
FORCE)

set (CMAKE_CXX_STANDARD
"20"
"23"
CACHE
STRING
"C++ standard to build with.")
Expand Down
2 changes: 1 addition & 1 deletion configure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ def identify_best_standard(cpp_standards, compiler):


if args.cpp_standard == '':
cpp_standards = ['23', '20', '17']
cpp_standards = ['23', '20']
args.cpp_standard = identify_best_standard(cpp_standards, compiler=args.cxx)


Expand Down